Reviewable status: 0 of 4 files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL)

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)

pyproject.toml line 7 at r1 (raw file):

[project]
name = "graminescaffolding"
version = "1.7.post0"

Why not ~UNRELEASED as you do in core Gramine?

graminescaffolding/__init__.py line 5 at r1 (raw file):

#                    Wojtek Porczyk <[email protected]>

__version__ = "1.7.post0"

ditto

Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)

pyproject.toml line 7 at r1 (raw file):
Because you can't have arbitrary strings as part of python (strict) version:
https://packaging.python.org/en/latest/specifications/version-specifiers/
There is a limited set of allowed suffixes, a for alpha, b for beta, rc for release candidate, .post and .dev (note dots) for devel versions. They all carry a decimal number and nothing else.

We already have a similar problem with alpine that also has limitation in version syntax, but we can work around that problem, because APKBUILD is a shell script, so I place real version in a variable and sed it. I reasonably could have worked that around in __init__.py (which is also executable), but not in pyproject.toml (which is declarative).

% python3
Python 3.9.2 (default, Feb 28 2021, 17:03:44) 
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from packaging.version import Version
>>> Version('1.7.post0')
<Version('1.7.post0')>
>>> Version('1.7.post~UNRELEASED')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/packaging/version.py", line 298, in __init__
    raise InvalidVersion("Invalid version: '{0}'".format(version))
packaging.version.InvalidVersion: Invalid version: '1.7.post~UNRELEASED'

I have an adapter for that in another version of release.sh script (gramineproject/gramine#), which I have not yet pushed.

graminescaffolding/__init__.py line 5 at r1 (raw file):

ditto

Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)

pyproject.toml line 7 at r1 (raw file):

gramineproject/gramine#1788 was that missing link

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Reviewed 2 of 4 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved